dependabot: move rust-vmm updates to their own PR #5370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-vmm deps have to be updated in lockstep most of the time, due to tight inter-dependencies. However, releasing new versions of all rust-vmm crates often takes time, and having dependabot include partial rust-vmm updates in its big PR of the week just results in broken dependabot PRs. Thus, just sort out the rust-vmm dependencies into a separate PR (dependabot opens one PR per "group", and each dependency update is only included in the first group that matches it). Signed-off-by: Patrick Roy <[email protected]>
Having it set to 100 is not very useful (the number is from before we were using grouped updates). With the way dependabot is configured, we can at most get 2 PRs at the same time (as dependabot will only open at most one PR per group, and we have two groups). We could set it to 2, but that can cause problems, see rust-vmm/kvm#336. Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
zulinx86
approved these changes
Aug 13, 2025
bchalios
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-vmm deps have to be updated in lockstep most of the time, due to
tight inter-dependencies. However, releasing new versions of all
rust-vmm crates often takes time, and having dependabot include partial
rust-vmm updates in its big PR of the week just results in broken
dependabot PRs. Thus, just sort out the rust-vmm dependencies into a
separate PR
I've tested this over in my fork, and it produced roypat#124
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.